Patchwork D7627: config: drop debug messages saying where config was read from

login
register
mail settings
Submitter phabricator
Date Dec. 17, 2019, 4:44 p.m.
Message ID <26ae3ce66da946c2965d7cbdcbcec91b@localhost.localdomain>
Download mbox | patch
Permalink /patch/43928/
State Not Applicable
Headers show

Comments

phabricator - Dec. 17, 2019, 4:44 p.m.
Closed by commit rHG6b6872822b32: config: drop debug messages saying where config was read from (authored by martinvonz).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7627?vs=18809&id=18816

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7627/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7627

AFFECTED FILES
  mercurial/commands.py
  tests/test-hgrc.t

CHANGE DETAILS




To: martinvonz, #hg-reviewers, pulkit
Cc: pulkit, mharbison72, mercurial-devel

Patch

diff --git a/tests/test-hgrc.t b/tests/test-hgrc.t
--- a/tests/test-hgrc.t
+++ b/tests/test-hgrc.t
@@ -197,9 +197,6 @@ 
 with environment variables
 
   $ PAGER=p1 EDITOR=e1 VISUAL=e2 hg showconfig --debug
-  set config by: $EDITOR
-  set config by: $VISUAL
-  set config by: $PAGER
   read config from: $TESTTMP/hgrc
   repo: bundle.mainreporoot=$TESTTMP
   $PAGER: pager.pager=p1
diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -2224,8 +2224,8 @@ 
         if t == b'path':
             ui.debug(b'read config from: %s\n' % f)
         elif t == b'items':
-            for section, name, value, source in f:
-                ui.debug(b'set config by: %s\n' % source)
+            # Don't print anything for 'items'.
+            pass
         else:
             raise error.ProgrammingError(b'unknown rctype: %s' % t)
     untrusted = bool(opts.get(b'untrusted'))