Patchwork D7673: util: rename a variable to avoid confusing pytype

login
register
mail settings
Submitter phabricator
Date Dec. 16, 2019, 6:32 a.m.
Message ID <9b3b3e0887176b0e83d5ec6c9843cc86@localhost.localdomain>
Download mbox | patch
Permalink /patch/43858/
State Not Applicable
Headers show

Comments

phabricator - Dec. 16, 2019, 6:32 a.m.
Closed by commit rHGeff050dbb703: util: rename a variable to avoid confusing pytype (authored by mharbison72).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7673?vs=18737&id=18749

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7673/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7673

AFFECTED FILES
  mercurial/util.py

CHANGE DETAILS




To: mharbison72, #hg-reviewers, pulkit
Cc: mercurial-devel

Patch

diff --git a/mercurial/util.py b/mercurial/util.py
--- a/mercurial/util.py
+++ b/mercurial/util.py
@@ -1195,12 +1195,12 @@ 
     '''cache the result of function calls'''
     # XXX doesn't handle keywords args
     if func.__code__.co_argcount == 0:
-        cache = []
+        listcache = []
 
         def f():
-            if len(cache) == 0:
-                cache.append(func())
-            return cache[0]
+            if len(listcache) == 0:
+                listcache.append(func())
+            return listcache[0]
 
         return f
     cache = {}