Patchwork D7541: mail: use procutil.shellsplit instead of bytes.split to parse command

login
register
mail settings
Submitter phabricator
Date Dec. 10, 2019, 3:46 p.m.
Message ID <8bd40988048cfb2c54699faaff8b3515@localhost.localdomain>
Download mbox | patch
Permalink /patch/43675/
State Not Applicable
Headers show

Comments

phabricator - Dec. 10, 2019, 3:46 p.m.
Closed by commit rHG8f26dd09aa78: mail: use procutil.shellsplit instead of bytes.split to parse command (authored by jcristau).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7541?vs=18419&id=18576

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7541/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7541

AFFECTED FILES
  mercurial/mail.py

CHANGE DETAILS




To: jcristau, #hg-reviewers, pulkit
Cc: mercurial-devel

Patch

diff --git a/mercurial/mail.py b/mercurial/mail.py
--- a/mercurial/mail.py
+++ b/mercurial/mail.py
@@ -197,7 +197,7 @@ 
         raise error.Abort(
             b'%s %s'
             % (
-                os.path.basename(program.split(None, 1)[0]),
+                os.path.basename(procutil.shellsplit(program)[0]),
                 procutil.explainexit(ret),
             )
         )