Patchwork D7557: annotate: describe --skip as taking a revset

login
register
mail settings
Submitter phabricator
Date Dec. 6, 2019, 6 p.m.
Message ID <differential-rev-PHID-DREV-2icpiqk5gdji4dk537kh-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/43605/
State Superseded
Headers show

Comments

phabricator - Dec. 6, 2019, 6 p.m.
durin42 created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  It's obvious to me, but probably wouldn't be obvious to a novice user.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7557

AFFECTED FILES
  mercurial/commands.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mjpieters, mercurial-devel
phabricator - Dec. 6, 2019, 6:10 p.m.
pulkit added a comment.


  Isn't it that where ever we says `revisions` we imply `revsets`?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7557/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7557

To: durin42, #hg-reviewers
Cc: pulkit, mjpieters, mercurial-devel
phabricator - Dec. 6, 2019, 6:12 p.m.
durin42 added a comment.


  It said `revision` before, so at a minimum we should add an `s`...
  
  (I don't know if we imply revset when we say revisions.)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7557/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7557

To: durin42, #hg-reviewers
Cc: pulkit, mjpieters, mercurial-devel

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -362,7 +362,7 @@ 
             b'',
             b'skip',
             [],
-            _(b'revision to not display (EXPERIMENTAL)'),
+            _(b'revset to not display (EXPERIMENTAL)'),
             _(b'REV'),
         ),
     ]