Patchwork D7537: githelp: fix a `str` type conditional for py3

login
register
mail settings
Submitter phabricator
Date Dec. 2, 2019, 9:56 p.m.
Message ID <e35280757337afb2a293b7e5fca6b75b@localhost.localdomain>
Download mbox | patch
Permalink /patch/43573/
State Not Applicable
Headers show

Comments

phabricator - Dec. 2, 2019, 9:56 p.m.
Closed by commit rHG24d0189238f1: githelp: fix a `str` type conditional for py3 (authored by mharbison72).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7537?vs=18413&id=18430

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7537/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7537

AFFECTED FILES
  hgext/githelp.py

CHANGE DETAILS




To: mharbison72, #hg-reviewers, dlax, pulkit
Cc: dlax, mercurial-devel

Patch

diff --git a/hgext/githelp.py b/hgext/githelp.py
--- a/hgext/githelp.py
+++ b/hgext/githelp.py
@@ -115,7 +115,7 @@ 
     args = list([convert(x) for x in args])
     opts = dict(
         [
-            (k, convert(v)) if isinstance(v, str) else (k, v)
+            (k, convert(v)) if isinstance(v, bytes) else (k, v)
             for k, v in pycompat.iteritems(opts)
         ]
     )