Patchwork D7540: tests: cover revision conversion logic in githelp tests

login
register
mail settings
Submitter phabricator
Date Dec. 2, 2019, 9:22 a.m.
Message ID <differential-rev-PHID-DREV-5c5o6pqicmc6up52szo4-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/43553/
State Superseded
Headers show

Comments

phabricator - Dec. 2, 2019, 9:22 a.m.
dlax created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  There was no test involving actual conversion of option values when they
  contain a git revision name (to be converted as a hg one by
  hgext.githelp.convert()). Adding one. This test would fail on Python 3
  without https://phab.mercurial-scm.org/D7537.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D7540

AFFECTED FILES
  tests/test-githelp.t

CHANGE DETAILS




To: dlax, #hg-reviewers
Cc: mercurial-devel
phabricator - Dec. 2, 2019, 5:44 p.m.
mharbison72 added inline comments.
mharbison72 accepted this revision.

INLINE COMMENTS

> test-githelp.t:269
> +  $ hg githelp -- git commit --reuse-message HEAD~
> +  hg commit -M .~1
> +

Not a problem with this change, but it doesn't look like commit has a `-M` option.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7540/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7540

To: dlax, #hg-reviewers, pulkit, mharbison72
Cc: mharbison72, mercurial-devel

Patch

diff --git a/tests/test-githelp.t b/tests/test-githelp.t
--- a/tests/test-githelp.t
+++ b/tests/test-githelp.t
@@ -264,6 +264,10 @@ 
   $ hg githelp -- git commit --reuse-message deadbeef
   hg commit -M deadbeef
 
+githelp for reuse message using HEAD
+  $ hg githelp -- git commit --reuse-message HEAD~
+  hg commit -M .~1
+
 githelp for apply with no options
   $ hg githelp -- apply
   hg import --no-commit