Patchwork [4,of,4,resend,revset,log] log: changed implementation to use graphlog code

login
register
mail settings
Submitter Mads Kiilerich
Date April 15, 2014, 12:30 a.m.
Message ID <534C7D98.8060109@kiilerich.com>
Download mbox | patch
Permalink /patch/4352/
State Accepted
Commit 69402eb72115417b67c86eef6161e5f11394fb2f
Headers show

Comments

Mads Kiilerich - April 15, 2014, 12:30 a.m.
On 04/15/2014 02:23 AM, Mads Kiilerich wrote:
> # HG changeset patch
> # User Lucas Moscovicz <lmoscovicz@fb.com>
> # Date 1393629056 28800
> #      Fri Feb 28 15:10:56 2014 -0800
> # Node ID 6e181aad6874b4180a45401d0ebd2bf170f66a0f
> # Parent  8460539633a1ed98d7119c90699a5f8b0d0a4122
> log: changed implementation to use graphlog code

The previous patches looks good to me now but I cannot vouch for this one.

Tests fails with:


so apparently it changes the ordering in some cases. I haven't 
investigated why.

https://bitbucket.org/lmoscovicz/mercurial/commits/4abd78b049715710c4c0553c6823456266a0b8da 
shows the same behaviour - that is probably why it only was sent as an 
RFC in http://markmail.org/message/z7aoqcl4tfnp5kcm .

/Mads

Patch

--- a/tests/test-glog.t
+++ b/tests/test-glog.t
@@ -1972,8 +1972,9 @@  Test --follow and forward --rev
    +++ glog.nodes       * (glob)
    @@ -1,3 +1,3 @@
    -nodetag 6
+  -nodetag 7
     nodetag 8
-   nodetag 7
+  +nodetag 7
    +nodetag 6

  Test --follow-first and forward --rev
@@ -1988,8 +1989,9 @@  Test --follow-first and forward --rev
    +++ glog.nodes       * (glob)
    @@ -1,3 +1,3 @@
    -nodetag 6
+  -nodetag 7
     nodetag 8
-   nodetag 7
+  +nodetag 7
    +nodetag 6

  Test --follow and backward --rev