Patchwork D7508: relnotes: add note about changes to match.{explicit, reverse}dir

login
register
mail settings
Submitter phabricator
Date Nov. 25, 2019, 3:32 p.m.
Message ID <5cd318e6705694a5a801b18c38c4bb8c@localhost.localdomain>
Download mbox | patch
Permalink /patch/43517/
State Not Applicable
Headers show

Comments

phabricator - Nov. 25, 2019, 3:32 p.m.
Closed by commit rHG32aa6cefb8f3: relnotes: add note about changes to match.{explicit,reverse}dir (authored by martinvonz).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7508?vs=18322&id=18389

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7508/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7508

AFFECTED FILES
  relnotes/next

CHANGE DETAILS




To: martinvonz, #hg-reviewers, dlax, pulkit
Cc: dlax, mercurial-devel

Patch

diff --git a/relnotes/next b/relnotes/next
--- a/relnotes/next
+++ b/relnotes/next
@@ -15,3 +15,9 @@ 
 
 == Internal API Changes ==
 
+ * Matcher instances no longer have a `explicitdir` property. Consider
+   rewriting your code to use `repo.wvfs.isdir()` and/or
+   `ctx.hasdir()` instead. Also, the `traversedir` property is now
+   also called when only `explicitdir` used to be called. That may
+   mean that you can simply remove the use of `explicitdir` if you
+   were already using `traversedir`.