Submitter | phabricator |
---|---|
Date | Nov. 24, 2019, 4:07 a.m. |
Message ID | <differential-rev-PHID-DREV-up3wqkwozemkjaequzoc-req@mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/43508/ |
State | Superseded |
Headers | show |
Comments
dlax added a comment. dlax accepted this revision. Looks like dead code REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7516/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7516 To: mharbison72, #hg-reviewers, dlax Cc: dlax, mercurial-devel
mharbison72 added a comment.
mharbison72 added a subscriber: yuja.
In D7516#110537 <https://phab.mercurial-scm.org/D7516#110537>, @dlax wrote:
> Looks like dead code
It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here). It also might be a WIP, given the comment in `join()`. @yuja?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7516/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7516
To: mharbison72, #hg-reviewers, dlax
Cc: yuja, dlax, mercurial-devel
> It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here). It also might be a WIP, given the comment in `join()`. @yuja?
`{sessionvars}` (with no `%template`) would crash without this change.
Queued, thanks.
yuja added a comment.
> It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here). It also might be a WIP, given the comment in `join()`. @yuja?
`{sessionvars}` (with no `%template`) would crash without this change.
Queued, thanks.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7516/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7516
To: mharbison72, #hg-reviewers, dlax
Cc: yuja, dlax, mercurial-devel
Patch
diff --git a/mercurial/hgweb/webutil.py b/mercurial/hgweb/webutil.py --- a/mercurial/hgweb/webutil.py +++ b/mercurial/hgweb/webutil.py @@ -865,7 +865,7 @@ raise error.ParseError(_(b'not displayable without template')) def show(self, context, mapping): - return self.join(context, b'') + return self.join(context, mapping, b'') def tobool(self, context, mapping): return bool(self._vars)