Patchwork D7516: webutil: add missing argument to join()

login
register
mail settings
Submitter phabricator
Date Nov. 24, 2019, 4:07 a.m.
Message ID <differential-rev-PHID-DREV-up3wqkwozemkjaequzoc-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/43508/
State Superseded
Headers show

Comments

phabricator - Nov. 24, 2019, 4:07 a.m.
mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D7516

AFFECTED FILES
  mercurial/hgweb/webutil.py

CHANGE DETAILS




To: mharbison72, #hg-reviewers
Cc: mercurial-devel
phabricator - Nov. 24, 2019, 8:50 a.m.
dlax added a comment.
dlax accepted this revision.


  Looks like dead code

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7516/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7516

To: mharbison72, #hg-reviewers, dlax
Cc: dlax, mercurial-devel
phabricator - Nov. 24, 2019, 2:17 p.m.
mharbison72 added a comment.
mharbison72 added a subscriber: yuja.


  In D7516#110537 <https://phab.mercurial-scm.org/D7516#110537>, @dlax wrote:
  
  > Looks like dead code
  
  It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here).  It also might be a WIP, given the comment in `join()`.  @yuja?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7516/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7516

To: mharbison72, #hg-reviewers, dlax
Cc: yuja, dlax, mercurial-devel
Yuya Nishihara - Nov. 24, 2019, 3:05 p.m.
>   It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here).  It also might be a WIP, given the comment in `join()`.  @yuja?

`{sessionvars}` (with no `%template`) would crash without this change.
Queued, thanks.
phabricator - Nov. 24, 2019, 3:07 p.m.
yuja added a comment.


  >   It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here).  It also might be a WIP, given the comment in `join()`.  @yuja?
  
  `{sessionvars}` (with no `%template`) would crash without this change.
  Queued, thanks.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7516/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7516

To: mharbison72, #hg-reviewers, dlax
Cc: yuja, dlax, mercurial-devel

Patch

diff --git a/mercurial/hgweb/webutil.py b/mercurial/hgweb/webutil.py
--- a/mercurial/hgweb/webutil.py
+++ b/mercurial/hgweb/webutil.py
@@ -865,7 +865,7 @@ 
         raise error.ParseError(_(b'not displayable without template'))
 
     def show(self, context, mapping):
-        return self.join(context, b'')
+        return self.join(context, mapping, b'')
 
     def tobool(self, context, mapping):
         return bool(self._vars)