Patchwork D7508: relnotes: add note about changes to match.{explicit, reverse}dir

login
register
mail settings
Submitter phabricator
Date Nov. 22, 2019, 7:09 p.m.
Message ID <differential-rev-PHID-DREV-uqc57f4yu3h3y2l43wll-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/43447/
State Superseded
Headers show

Comments

phabricator - Nov. 22, 2019, 7:09 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D7508

AFFECTED FILES
  relnotes/next

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel
phabricator - Nov. 22, 2019, 8:14 p.m.
dlax added inline comments.

INLINE COMMENTS

> next:22
> +   also called when only `explicitdir` used to be called. That may
> +   mean that you can simple remove the use of `explicitdir` if you
> +   were already using `traversedir`.

simple -> simply?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7508/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7508

To: martinvonz, #hg-reviewers
Cc: dlax, mercurial-devel

Patch

diff --git a/relnotes/next b/relnotes/next
--- a/relnotes/next
+++ b/relnotes/next
@@ -15,3 +15,9 @@ 
 
 == Internal API Changes ==
 
+ * Matcher instances no longer have a `explicitdir` property. Consider
+   rewriting your code to use `repo.wvfs.isdir()` and/or
+   `ctx.hasdir()` instead. Also, the `traversedir` property is now
+   also called when only `explicitdir` used to be called. That may
+   mean that you can simple remove the use of `explicitdir` if you
+   were already using `traversedir`.