Patchwork D7500: repoview: add a test for changelog filtering trigger for `hg annotate`

login
register
mail settings
Submitter phabricator
Date Nov. 22, 2019, 9:23 a.m.
Message ID <differential-rev-PHID-DREV-wyywgzoer7swwavxlphd-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/43433/
State Superseded
Headers show

Comments

phabricator - Nov. 22, 2019, 9:23 a.m.
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7500

AFFECTED FILES
  tests/test-repo-filters-tiptoe.t

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel
phabricator - Nov. 22, 2019, 7:59 p.m.
martinvonz added a comment.


  Could we just add all these tests from the beginning? It seems they would look almost the same if added early in the series, just with some extra "getting filtered repo" lines (or whatever they say). If the tests were added earlier, it would be clearer which changes affected which tests.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7500/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7500

To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel
phabricator - Nov. 22, 2019, 9:14 p.m.
marmoute added a comment.


  Yes we could. (right now, the test are introduced right before the series of change fixing it (or right after the last chngeset in that series)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7500/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7500

To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel
phabricator - Nov. 23, 2019, midnight
martinvonz added a comment.


  In D7500#110252 <https://phab.mercurial-scm.org/D7500#110252>, @marmoute wrote:
  
  > Yes we could.
  
  Please do if you don't mind. Thanks.
  
  > (right now, the test are introduced right before the series of change fixing it (or right after the last chngeset in that series)
  
  Yes, I noticed.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7500/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7500

To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel
phabricator - Nov. 23, 2019, 1:07 p.m.
marmoute added a comment.
marmoute abandoned this revision.


  This was pruned, but phab apparently does not detect this.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7500/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7500

To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel

Patch

diff --git a/tests/test-repo-filters-tiptoe.t b/tests/test-repo-filters-tiptoe.t
--- a/tests/test-repo-filters-tiptoe.t
+++ b/tests/test-repo-filters-tiptoe.t
@@ -130,3 +130,19 @@ 
    some line
    in a
   +file
+
+using annotate
+
+- file with a single change
+
+  $ hg annotate a
+  debug.filters: computing revision filter for "visible"
+  0: a
+
+- file with multiple change
+
+  $ hg annotate z
+  debug.filters: computing revision filter for "visible"
+  0: some line
+  1: in a
+  2: file