Patchwork D7491: changectx: mark the parents of the working copy as non filtered

login
register
mail settings
Submitter phabricator
Date Nov. 22, 2019, 9:23 a.m.
Message ID <differential-rev-PHID-DREV-bnirsizayuvzykcixqf2-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/43427/
State Superseded
Headers show

Comments

phabricator - Nov. 22, 2019, 9:23 a.m.
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  If we successfully accessed the working copy, its parents are not filtered.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7491

AFFECTED FILES
  mercurial/context.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel
phabricator - Nov. 24, 2019, 12:55 a.m.
This revision is now accepted and ready to land.
indygreg added inline comments.
indygreg accepted this revision.

INLINE COMMENTS

> context.py:1522
> +        return [
> +            changectx(self._repo, unfi.changelog.rev(n), n, False) for n in p
> +        ]

I'm adding a named argument in flight.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7491/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7491

To: marmoute, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel

Patch

diff --git a/mercurial/context.py b/mercurial/context.py
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -1512,7 +1512,9 @@ 
             p = p[:-1]
         # use unfiltered repo to delay/avoid loading obsmarkers
         unfi = self._repo.unfiltered()
-        return [changectx(self._repo, unfi.changelog.rev(n), n) for n in p]
+        return [
+            changectx(self._repo, unfi.changelog.rev(n), n, False) for n in p
+        ]
 
     def _fileinfo(self, path):
         # populate __dict__['_manifest'] as workingctx has no _manifestdelta