Patchwork D7486: locarepo: also fastpath `nullid` lookup in __getitem__

login
register
mail settings
Submitter phabricator
Date Nov. 22, 2019, 9:22 a.m.
Message ID <differential-rev-PHID-DREV-qbrtrswurtehyoy2jqjd-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/43422/
State Superseded
Headers show

Comments

phabricator - Nov. 22, 2019, 9:22 a.m.
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We already use that fastpath for `"null"` and `nullrev`, using it for `nullid`
  is similar.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7486

AFFECTED FILES
  mercurial/localrepo.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -1531,7 +1531,7 @@ 
             ]
 
         # dealing with some special values
-        if changeid == b'null' or changeid == nullrev:
+        if changeid == b'null' or changeid == nullrev or changeid == nullid:
             return context.changectx(self, nullrev, nullid, False)
         if changeid == b'tip':
             node = self.changelog.tip()