Patchwork D7476: repoview: add a 'devel.debug.repo-filter' option

login
register
mail settings
Submitter phabricator
Date Nov. 22, 2019, 9:19 a.m.
Message ID <differential-rev-PHID-DREV-jxgsnsaaolam7ihgu6cc-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/43410/
State Superseded
Headers show

Comments

phabricator - Nov. 22, 2019, 9:19 a.m.
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  If set, there will be debug message when a filter computation is triggered.
  
  This is going to be useful to remove various filtering trigger and to test they
  do not get reintroduced.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7476

AFFECTED FILES
  mercurial/configitems.py
  mercurial/repoview.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/repoview.py b/mercurial/repoview.py
--- a/mercurial/repoview.py
+++ b/mercurial/repoview.py
@@ -217,6 +217,9 @@ 
     hidden-state and must be visible. They are dynamic and hence we should not
     cache it's result"""
     if filtername not in repo.filteredrevcache:
+        if repo.ui.configbool(b'devel', b'debug.repo-filters'):
+            msg = b'debug.filters: computing revision filter for "%s"\n'
+            repo.ui.debug(msg % filtername)
         func = filtertable[filtername]
         if visibilityexceptions:
             return func(repo.unfiltered, visibilityexceptions)
diff --git a/mercurial/configitems.py b/mercurial/configitems.py
--- a/mercurial/configitems.py
+++ b/mercurial/configitems.py
@@ -433,6 +433,9 @@ 
     b'devel', b'debug.extensions', default=False,
 )
 coreconfigitem(
+    b'devel', b'debug.repo-filters', default=False,
+)
+coreconfigitem(
     b'devel', b'debug.peer-request', default=False,
 )
 coreconfigitem(