Patchwork D7258: makefile: use Python 3 by default outside of Windows (BC)

login
register
mail settings
Submitter phabricator
Date Nov. 22, 2019, 4:09 a.m.
Message ID <bd2e7835b79d9dea2e08acc9c568993a@localhost.localdomain>
Download mbox | patch
Permalink /patch/43406/
State Not Applicable
Headers show

Comments

phabricator - Nov. 22, 2019, 4:09 a.m.
indygreg edited the summary of this revision.
indygreg retitled this revision from "makefile: use Python 3 by default (BC)" to "makefile: use Python 3 by default outside of Windows (BC)".
indygreg updated this revision to Diff 18278.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7258?vs=18277&id=18278

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7258/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7258

AFFECTED FILES
  Makefile

CHANGE DETAILS




To: indygreg, #hg-reviewers, martinvonz, mharbison72
Cc: yuja, mharbison72, durin42, dlax, martinvonz, mercurial-devel

Patch

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -5,7 +5,18 @@ 
 # % make PREFIX=/opt/ install
 
 export PREFIX=/usr/local
+
+# Default to Python 3.
+#
+# But there are still unresolved issues with Python 3 on Windows. See
+# discussion in https://phab.mercurial-scm.org/D7258. So we keep things
+# on `python.exe` there (which may or may not be Python 3).
+ifeq ($(OS),Windows_NT)
 PYTHON?=python
+else
+PYTHON?=python3
+endif
+
 $(eval HGROOT := $(shell pwd))
 HGPYTHONS ?= $(HGROOT)/build/pythons
 PURE=