Patchwork [1,of,2] repoview: drop duplicated lookup

login
register
mail settings
Submitter Pierre-Yves David
Date April 13, 2014, 8:45 p.m.
Message ID <9be440eaf7acf9c3b3df.1397421944@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/4338/
State Accepted
Commit 5152afc145e5f0a67ba4ef6f392d98c383c1a116
Headers show

Comments

Pierre-Yves David - April 13, 2014, 8:45 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1397421571 14400
#      Sun Apr 13 16:39:31 2014 -0400
# Node ID 9be440eaf7acf9c3b3dfc9f551537c32b5fe107c
# Parent  054309870e8372d756050919881cdc717f3e6b53
repoview: drop duplicated lookup

We are already looking for local tag the line just above. We can safely drop
this extra lookup.

Patch

diff --git a/mercurial/repoview.py b/mercurial/repoview.py
--- a/mercurial/repoview.py
+++ b/mercurial/repoview.py
@@ -39,11 +39,10 @@  def _gethiddenblockers(repo):
             blockers.append(repo[bm].rev())
         tags = {}
         tagsmod.readlocaltags(repo.ui, repo, tags, {})
         if tags:
             blockers.extend(repo[t[0]].rev() for t in tags.values())
-        blockers.extend(repo[t].rev() for t in tags)
     return blockers
 
 def computehidden(repo):
     """compute the set of hidden revision to filter