Patchwork D7438: commit: drop unused "vdirs" argument from repo.checkcommitpatterns()

login
register
mail settings
Submitter phabricator
Date Nov. 19, 2019, 1:14 p.m.
Message ID <2796d6bfc9e639d17b81a8fb8ee61e14@localhost.localdomain>
Download mbox | patch
Permalink /patch/43358/
State Not Applicable
Headers show

Comments

phabricator - Nov. 19, 2019, 1:14 p.m.
Closed by commit rHGf965b1027fb0: commit: drop unused &quot;vdirs&quot; argument from repo.checkcommitpatterns() (authored by martinvonz).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7438?vs=18173&id=18235

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7438/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7438

AFFECTED FILES
  mercurial/cmdutil.py
  mercurial/interfaces/repository.py
  mercurial/localrepo.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers, Alphare, pulkit
Cc: mercurial-devel

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -2789,7 +2789,7 @@ 
 
         return fparent1
 
-    def checkcommitpatterns(self, wctx, vdirs, match, status, fail):
+    def checkcommitpatterns(self, wctx, match, status, fail):
         """check for commit arguments that aren't committable"""
         if match.isexact() or match.prefix():
             matched = set(status.modified + status.added + status.removed)
@@ -2838,8 +2838,6 @@ 
             match = matchmod.always()
 
         if not force:
-            vdirs = []
-            match.explicitdir = vdirs.append
             match.bad = fail
 
         # lock() for recent changelog (see issue4368)
@@ -2868,7 +2866,7 @@ 
 
             # make sure all explicit patterns are matched
             if not force:
-                self.checkcommitpatterns(wctx, vdirs, match, status, fail)
+                self.checkcommitpatterns(wctx, match, status, fail)
 
             cctx = context.workingcommitctx(
                 self, status, text, user, date, extra
diff --git a/mercurial/interfaces/repository.py b/mercurial/interfaces/repository.py
--- a/mercurial/interfaces/repository.py
+++ b/mercurial/interfaces/repository.py
@@ -1746,7 +1746,7 @@ 
     def currentwlock():
         """Return the wlock if it's held or None."""
 
-    def checkcommitpatterns(wctx, vdirs, match, status, fail):
+    def checkcommitpatterns(wctx, match, status, fail):
         pass
 
     def commit(
diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py
--- a/mercurial/cmdutil.py
+++ b/mercurial/cmdutil.py
@@ -427,9 +427,7 @@ 
 
         force = opts.get(b'force')
         if not force:
-            vdirs = []
             match = matchmod.badmatch(match, fail)
-            match.explicitdir = vdirs.append
 
         status = repo.status(match=match)
 
@@ -457,7 +455,7 @@ 
                     raise error.Abort(dirtyreason)
 
         if not force:
-            repo.checkcommitpatterns(wctx, vdirs, match, status, fail)
+            repo.checkcommitpatterns(wctx, match, status, fail)
         diffopts = patch.difffeatureopts(
             ui,
             opts=opts,