Patchwork D7448: tests: check for Windows line endings

login
register
mail settings
Submitter phabricator
Date Nov. 16, 2019, 8:09 p.m.
Message ID <differential-rev-PHID-DREV-uezco2qa4yp7bmvrziiy-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/43314/
State Superseded
Headers show

Comments

phabricator - Nov. 16, 2019, 8:09 p.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We shouldn't generally be using Windows line endings in files
  under version control. I've accidentally committed a few files
  with Windows line endings recently. So let's add a test for
  this.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D7448

AFFECTED FILES
  tests/test-check-code.t

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-check-code.t b/tests/test-check-code.t
--- a/tests/test-check-code.t
+++ b/tests/test-check-code.t
@@ -83,3 +83,9 @@ 
 Keep python3 tests sorted:
   $ sort < contrib/python3-whitelist > $TESTTMP/py3sorted
   $ cmp contrib/python3-whitelist $TESTTMP/py3sorted || echo 'Please sort passing tests!'
+
+Keep Windows line endings in check
+
+  $ hg files 'set:eol(dos)'
+  contrib/win32/hg.bat
+  contrib/win32/mercurial.ini