Patchwork D7428: tags: don't check for clean files when checking for dirty working copy

login
register
mail settings
Submitter phabricator
Date Nov. 15, 2019, 6:04 a.m.
Message ID <differential-rev-PHID-DREV-b5q7zr4j2rm2i5olrdvw-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/43268/
State Superseded
Headers show

Comments

phabricator - Nov. 15, 2019, 6:04 a.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We didn't request status for clean files so there should never be any
  entries in the list of clean files (at least not since dd773340a085 <https://phab.mercurial-scm.org/rHGdd773340a0853818101e6c45e79d7e8eeaf47f4a>),
  but it's misleading to check the list.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D7428

AFFECTED FILES
  mercurial/tags.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/tags.py b/mercurial/tags.py
--- a/mercurial/tags.py
+++ b/mercurial/tags.py
@@ -580,7 +580,6 @@ 
                 st.deleted,
                 st.unknown,
                 st.ignored,
-                st.clean,
             )
         ):
             raise error.Abort(