Patchwork D7289: branchmap: correctly set()-ify list argument

login
register
mail settings
Submitter phabricator
Date Nov. 14, 2019, 9:05 p.m.
Message ID <332475d03ab870238b39dd3339eec2c6@localhost.localdomain>
Download mbox | patch
Permalink /patch/43191/
State Not Applicable
Headers show

Comments

phabricator - Nov. 14, 2019, 9:05 p.m.
durin42 edited the summary of this revision.
durin42 retitled this revision from "branchmap: always copy closednodes to a set" to "branchmap: correctly set()-ify list argument".
durin42 updated this revision to Diff 18077.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7289?vs=18063&id=18077

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7289/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7289

AFFECTED FILES
  mercurial/branchmap.py

CHANGE DETAILS




To: durin42, #hg-reviewers, indygreg, dlax
Cc: indygreg, mercurial-devel

Patch

diff --git a/mercurial/branchmap.py b/mercurial/branchmap.py
--- a/mercurial/branchmap.py
+++ b/mercurial/branchmap.py
@@ -105,7 +105,7 @@ 
                 remotebranchmap,
                 repo[rtiprev].node(),
                 rtiprev,
-                closednodes=closed,
+                closednodes=set(closed),
             )
 
             # Try to stick it as low as possible
@@ -177,7 +177,7 @@ 
         if closednodes is None:
             self._closednodes = set()
         else:
-            self._closednodes = closednodes
+            self._closednodes = set(closednodes)
         self._entries = dict(entries)
         # whether closed nodes are verified or not
         self._closedverified = False