Patchwork [03,of,12,misc,largefiles] largefiles: remove confusing handling of .bad return value - it is void

login
register
mail settings
Submitter Mads Kiilerich
Date April 13, 2014, 4:59 p.m.
Message ID <c577232987ac51936517.1397408346@localhost.localdomain>
Download mbox | patch
Permalink /patch/4319/
State Accepted
Commit 718f56c474147e35d6d6c2b4961e622dbe1324b0
Headers show

Comments

Mads Kiilerich - April 13, 2014, 4:59 p.m.
# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 1397407543 -7200
#      Sun Apr 13 18:45:43 2014 +0200
# Node ID c577232987ac51936517fc2dece1b316a3b8f42b
# Parent  5c878bec9e6586e029269870353b56bf5ebab5b7
largefiles: remove confusing handling of .bad return value - it is void

Patch

diff --git a/hgext/largefiles/overrides.py b/hgext/largefiles/overrides.py
--- a/hgext/largefiles/overrides.py
+++ b/hgext/largefiles/overrides.py
@@ -1157,7 +1157,7 @@  def overridecat(orig, ui, repo, file1, *
     origbadfn = m.bad
     def lfbadfn(f, msg):
         if not f in notbad:
-            return origbadfn(f, msg)
+            origbadfn(f, msg)
     m.bad = lfbadfn
     for f in ctx.walk(m):
         fp = cmdutil.makefileobj(repo, opts.get('output'), ctx.node(),