D7379: encoding: fix bad type annotation

Submitter	phabricator
Date	Nov. 14, 2019, 3:51 a.m.
Message ID	<differential-rev-PHID-DREV-gkd5eiootiihqpldltnm-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/43171/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Thu, 14 Nov 2019 03:51:05 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "durin42 (Augie Fackler)" <phabricator@mercurial-scm.org> Subject: D7379: encoding: fix bad type annotation Message-ID: <differential-rev-PHID-DREV-gkd5eiootiihqpldltnm-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-gkd5eiootiihqpldltnm Thread-Index: ZWQxYzQ4ODQwYjBiNTQyNmYyNmY1MWNjY2Rl MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "durin42 \(Augie Fackler\)" <phabricator+D7379+public+c07f912711c6af35@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Nov. 14, 2019, 3:51 a.m.

durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This function returns utf-8 in a bytes, not a unicode.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7379

AFFECTED FILES
  mercurial/encoding.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/encoding.py b/mercurial/encoding.py
--- a/mercurial/encoding.py
+++ b/mercurial/encoding.py
@@ -205,7 +205,7 @@ 
 
 
 def fromlocal(s):
-    # type: (bytes) -> Text
+    # type: (bytes) -> bytes
     """
     Convert a string from the local character encoding to UTF-8

Patchwork D7379: encoding: fix bad type annotation

Comments

Patch