Patchwork D7366: revlog: delete references to deleted nullid sentinel value

login
register
mail settings
Submitter phabricator
Date Nov. 11, 2019, 12:34 p.m.
Message ID <bcc7cc2103c8e5b8d90d51660641b8d4@localhost.localdomain>
Download mbox | patch
Permalink /patch/43106/
State Not Applicable
Headers show

Comments

phabricator - Nov. 11, 2019, 12:34 p.m.
Closed by commit rHGae5e39512ca0: revlog: delete references to deleted nullid sentinel value (authored by martinvonz).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7366?vs=17806&id=18003

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7366/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7366

AFFECTED FILES
  mercurial/cext/revlog.c

CHANGE DETAILS




To: martinvonz, #hg-reviewers, indygreg, pulkit
Cc: mercurial-devel

Patch

diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -62,10 +62,9 @@ 
  * This class has two behaviors.
  *
  * When used in a list-like way (with integer keys), we decode an
- * entry in a RevlogNG index file on demand. Our last entry is a
- * sentinel, always a nullid.  We have limited support for
+ * entry in a RevlogNG index file on demand. We have limited support for
  * integer-keyed insert and delete, only at elements right before the
- * sentinel.
+ * end.
  *
  * With string keys, we lazily perform a reverse mapping from node to
  * rev, using a base-16 trie.
@@ -2466,7 +2465,7 @@ 
 
 /*
  * Delete a numeric range of revs, which must be at the end of the
- * range, but exclude the sentinel nullid entry.
+ * range.
  */
 static int index_slice_del(indexObject *self, PyObject *item)
 {