Submitter | phabricator |
---|---|
Date | Nov. 8, 2019, 4:25 p.m. |
Message ID | <differential-rev-PHID-DREV-xhmc7f27q5tjl5vtnnjw-req@mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/42947/ |
State | Superseded |
Headers | show |
Comments
This revision is now accepted and ready to land. indygreg added inline comments. indygreg accepted this revision. INLINE COMMENTS > tags.py:198 > + assert repo.changelog.index.has_node( > + head > ), b"tag cache returned bogus head %s" % short(head) `repo.changelog` in loops is bad. If you could do a follow-up that aliases `repo.changelog.index.has_node` outside of the loop, it would be appreciated. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7342/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7342 To: marmoute, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel
Patch
diff --git a/mercurial/tags.py b/mercurial/tags.py --- a/mercurial/tags.py +++ b/mercurial/tags.py @@ -194,8 +194,8 @@ return alltags for head in reversed(heads): # oldest to newest - assert ( - head in repo.changelog.nodemap + assert repo.changelog.index.has_node( + head ), b"tag cache returned bogus head %s" % short(head) fnodes = _filterfnodes(tagfnode, reversed(heads)) alltags = _tagsfromfnodes(ui, repo, fnodes)