Patchwork D7330: index: use `index.has_node` in `analyzeremotephases`

login
register
mail settings
Submitter phabricator
Date Nov. 8, 2019, 4:24 p.m.
Message ID <differential-rev-PHID-DREV-uksowxxddqns5a56os5d-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/42933/
State Superseded
Headers show

Comments

phabricator - Nov. 8, 2019, 4:24 p.m.
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7330

AFFECTED FILES
  mercurial/phases.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/phases.py b/mercurial/phases.py
--- a/mercurial/phases.py
+++ b/mercurial/phases.py
@@ -672,7 +672,7 @@ 
     repo = repo.unfiltered()
     # build list from dictionary
     draftroots = []
-    nodemap = repo.changelog.nodemap  # to filter unknown nodes
+    has_node = repo.changelog.index.has_node  # to filter unknown nodes
     for nhex, phase in pycompat.iteritems(roots):
         if nhex == b'publishing':  # ignore data related to publish option
             continue
@@ -688,7 +688,7 @@ 
                     % nhex
                 )
         elif phase == draft:
-            if node in nodemap:
+            if has_node(node):
                 draftroots.append(node)
         else:
             repo.ui.warn(