D7325: revlog: use `index.rev` in `revlog.rev`

Submitter	phabricator
Date	Nov. 8, 2019, 1:34 p.m.
Message ID	<differential-rev-PHID-DREV-tx7dzx3egjcgd3qm42q2-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/42927/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Fri, 8 Nov 2019 13:34:19 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "marmoute (Pierre-Yves David)" <phabricator@mercurial-scm.org> Subject: D7325: revlog: use `index.rev` in `revlog.rev` Message-ID: <differential-rev-PHID-DREV-tx7dzx3egjcgd3qm42q2-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-tx7dzx3egjcgd3qm42q2 Thread-Index: ZmVjZmNmMzkzZjQ1ODQxNjA2MWNmMjM3ZjZk MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "marmoute \(Pierre-Yves David\)" <phabricator+D7325+public+3f8b923f73b38c8c@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Nov. 8, 2019, 1:34 p.m.

marmoute created this revision.
Herald added a reviewer: indygreg.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7325

AFFECTED FILES
  mercurial/revlog.py

CHANGE DETAILS




To: marmoute, indygreg, #hg-reviewers
Cc: mercurial-devel

phabricator - Nov. 8, 2019, 8:06 p.m.

This revision now requires changes to proceed.
indygreg added a comment.
indygreg requested changes to this revision.


  This needs a re-review depending on what happens in D7324 <https://phab.mercurial-scm.org/D7324>.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7325/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7325

To: marmoute, indygreg, #hg-reviewers
Cc: mercurial-devel

phabricator - Nov. 9, 2019, 12:37 a.m.

marmoute added a comment.
marmoute requested review of this revision.


  See my answer in D7324 <https://phab.mercurial-scm.org/D7324>, I am keeping the same exception that previously raised for now.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7325/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7325

To: marmoute, indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -687,7 +687,7 @@ 
 
     def rev(self, node):
         try:
-            return self.index.nodemap[node]
+            return self.index.rev(node)
         except TypeError:
             raise
         except error.RevlogError:

Patchwork D7325: revlog: use `index.rev` in `revlog.rev`

Comments

Patch