Patchwork D7292: changegroup: avoid shadowing a set with an int

login
register
mail settings
Submitter phabricator
Date Nov. 7, 2019, 8:36 a.m.
Message ID <a6e4d8d08ae1cbbf0adf0fa6f98b030b@localhost.localdomain>
Download mbox | patch
Permalink /patch/42885/
State Not Applicable
Headers show

Comments

phabricator - Nov. 7, 2019, 8:36 a.m.
Closed by commit rHGea0b44255a31: changegroup: avoid shadowing a set with an int (authored by durin42).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7292?vs=17662&id=17703

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7292/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7292

AFFECTED FILES
  mercurial/changegroup.py

CHANGE DETAILS




To: durin42, #hg-reviewers, indygreg
Cc: mercurial-devel

Patch

diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py
--- a/mercurial/changegroup.py
+++ b/mercurial/changegroup.py
@@ -315,15 +315,15 @@ 
             )
             self.callback = progress.increment
 
-            efiles = set()
+            efilesset = set()
 
             def onchangelog(cl, node):
-                efiles.update(cl.readfiles(node))
+                efilesset.update(cl.readfiles(node))
 
             self.changelogheader()
             deltas = self.deltaiter()
             cgnodes = cl.addgroup(deltas, csmap, trp, addrevisioncb=onchangelog)
-            efiles = len(efiles)
+            efiles = len(efilesset)
 
             if not cgnodes:
                 repo.ui.develwarn(