D7285: vfs: more attribute suppressions

Submitter	phabricator
Date	Nov. 6, 2019, 10:59 p.m.
Message ID	<differential-rev-PHID-DREV-nqnv3fq4k27xfdmyvner-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/42836/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Wed, 6 Nov 2019 22:59:43 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "durin42 (Augie Fackler)" <phabricator@mercurial-scm.org> Subject: D7285: vfs: more attribute suppressions Message-ID: <differential-rev-PHID-DREV-nqnv3fq4k27xfdmyvner-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-nqnv3fq4k27xfdmyvner Thread-Index: MTljNDNiNmVlNDBlMGZlNzRiZGRkNzhkMjY2 MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "durin42 \(Augie Fackler\)" <phabricator+D7285+public+da9e6371c3a19e9c@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Nov. 6, 2019, 10:59 p.m.

durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7285

AFFECTED FILES
  mercurial/vfs.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/vfs.py b/mercurial/vfs.py
--- a/mercurial/vfs.py
+++ b/mercurial/vfs.py
@@ -486,7 +486,9 @@ 
             threading.currentThread(),
             threading._MainThread,  # pytype: disable=module-attr
         ):
-            if not self._backgroundfilecloser:
+            if (
+                not self._backgroundfilecloser
+            ):  # pytype: disable=attribute-error
                 raise error.Abort(
                     _(
                         b'backgroundclose can only be used when a '
@@ -494,7 +496,9 @@ 
                     )
                 )
 
-            fp = delayclosedfile(fp, self._backgroundfilecloser)
+            fp = delayclosedfile(
+                fp, self._backgroundfilecloser
+            )  # pytype: disable=attribute-error
 
         return fp

Patchwork D7285: vfs: more attribute suppressions

Comments

Patch