Patchwork D7281: wireprototypes: disable pytype where it's just confused

login
register
mail settings
Submitter phabricator
Date Nov. 6, 2019, 10:58 p.m.
Message ID <differential-rev-PHID-DREV-hhrwhyaaa6inh27vsbbl-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/42832/
State Superseded
Headers show

Comments

phabricator - Nov. 6, 2019, 10:58 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  By inspection validnames is always a Set[bytes] here, but for some
  reason pytype is convinced it's a bytes. Let's disable the error for now.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7281

AFFECTED FILES
  mercurial/wireprototypes.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/wireprototypes.py b/mercurial/wireprototypes.py
--- a/mercurial/wireprototypes.py
+++ b/mercurial/wireprototypes.py
@@ -404,7 +404,7 @@ 
             )
             % config,
             hint=_(b'usable compression engines: %s')
-            % b', '.sorted(validnames),
+            % b', '.sorted(validnames),  # pytype: disable=attribute-error
         )
 
     return compengines