Submitter | phabricator |
---|---|
Date | Nov. 4, 2019, 9:20 p.m. |
Message ID | <differential-rev-PHID-DREV-b3e5dipm6vflseks5qsn-req@mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/42730/ |
State | Superseded |
Headers | show |
Comments
pulkit added a comment. This has already been pushed as https://www.mercurial-scm.org/repo/hg-committed/rev/c3bca833cb92 REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7221/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7221 To: durin42, #hg-reviewers, pulkit Cc: mercurial-devel
Herald added a subscriber: mercurial-patches. marmoute added a comment. Baymax does not catch stuff in `Accepted` state, but this diff is 6 months old, so resubmit if still relevant. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7221/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7221 To: durin42, #hg-reviewers, pulkit Cc: marmoute, mercurial-patches, mercurial-devel
indygreg added a comment. A similar patch already landed. I'm going to commandeer and close. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7221/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7221 To: durin42, #hg-reviewers, pulkit Cc: indygreg, marmoute, mercurial-patches, mercurial-devel
Patch
diff --git a/tests/hghave.py b/tests/hghave.py --- a/tests/hghave.py +++ b/tests/hghave.py @@ -987,4 +987,4 @@ version_regex = b'black, version ([0-9a-b.]+)' version = matchoutput(blackcmd, version_regex) sv = distutils.version.StrictVersion - return version and sv(version.group(1)) >= sv('19.10b0') + return version and sv(_strpath(version.group(1))) >= sv('19.10b0')