Patchwork D7189: git: use bytes in command name, not unicode

login
register
mail settings
Submitter phabricator
Date Nov. 1, 2019, 4:39 p.m.
Message ID <differential-rev-PHID-DREV-hcq7fmdvzdmrr7c2pzbg-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/42654/
State Superseded
Headers show

Comments

phabricator - Nov. 1, 2019, 4:39 p.m.
maho created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7189

AFFECTED FILES
  hgext/git/__init__.py

CHANGE DETAILS




To: maho, #hg-reviewers
Cc: mercurial-devel
phabricator - Nov. 6, 2019, 6:06 p.m.
durin42 added a comment.


  Thanks, I've folded this into my initial patch so I won't break Python 3!
  
  I'm hoping to come back to this topic soon and get an initial version of the git extension landed - mostly I want to clean up how manifests/trees work and then I think it's worth landing.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7189/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7189

To: maho, #hg-reviewers
Cc: durin42, mercurial-devel
phabricator - Feb. 7, 2020, 8 p.m.
This revision now requires changes to proceed.
baymax added a comment.
baymax requested changes to this revision.


  There seems to have been no activities on this Diff for the past 3 Months.
  
  By policy, we are automatically moving it out of the `need-review` state.
  
  Please, move it back to `need-review` without hesitation if this diff should still be discussed.
  
  :baymax:need-review-idle:

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7189/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7189

To: maho, #hg-reviewers, baymax
Cc: durin42, mercurial-devel
phabricator - March 3, 2020, 6:31 p.m.
durin42 added a comment.
durin42 added a reviewer: maho.
durin42 commandeered this revision.


  I've folded these into the base rev, thanks!

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7189/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7189

To: durin42, #hg-reviewers, baymax, maho
Cc: durin42, mercurial-devel

Patch

diff --git a/hgext/git/__init__.py b/hgext/git/__init__.py
--- a/hgext/git/__init__.py
+++ b/hgext/git/__init__.py
@@ -225,5 +225,5 @@ 
     extensions.wrapfunction(localrepo, 'makestore', _makestore)
     extensions.wrapfunction(localrepo, 'makefilestorage', _makefilestorage)
     # Inject --git flag for `hg init`
-    entry = extensions.wrapcommand(commands.table, 'init', init)
+    entry = extensions.wrapcommand(commands.table, b'init', init)
     entry[1].extend([('', 'git', None, 'setup up a git repository instead of hg')])