Patchwork D7179: revset: simplify checkstatus() by using any()

login
register
mail settings
Submitter phabricator
Date Oct. 30, 2019, 5:05 p.m.
Message ID <differential-rev-PHID-DREV-oypsavwomwybtwjuogu6-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/42617/
State Superseded
Headers show

Comments

phabricator - Oct. 30, 2019, 5:05 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7179

AFFECTED FILES
  mercurial/revset.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/revset.py b/mercurial/revset.py
--- a/mercurial/revset.py
+++ b/mercurial/revset.py
@@ -689,19 +689,15 @@ 
             if fname not in c.files():
                 return False
         else:
-            for f in c.files():
-                if m(f):
-                    break
-            else:
+            if not any(m(f) for f in c.files()):
                 return False
         files = repo.status(c.p1().node(), c.node())[field]
         if fname is not None:
             if fname in files:
                 return True
         else:
-            for f in files:
-                if m(f):
-                    return True
+            if any(m(f) for f in files):
+                return True
 
     return subset.filter(matches, condrepr=(b'<status[%r] %r>', field, pat))