Patchwork [3,of,4,STABLE] packaging: avoid running bare "make install" in debian/rules

login
register
mail settings
Submitter Denis Laxalde
Date Oct. 23, 2019, 3:22 p.m.
Message ID <11c85873e106c85621ef.1571844141@steppe.local>
Download mbox | patch
Permalink /patch/42541/
State Accepted
Headers show

Comments

Denis Laxalde - Oct. 23, 2019, 3:22 p.m.
# HG changeset patch
# User Denis Laxalde <denis.laxalde@logilab.fr>
# Date 1571843937 -7200
#      Wed Oct 23 17:18:57 2019 +0200
# Branch stable
# Node ID 11c85873e106c85621ef85b67b3c64788e24a8d3
# Parent  cdf6db1f4faf64e99c5bef725459e8da0f3c6f04
packaging: avoid running bare "make install" in debian/rules

We change the "override_dh_install" target to "override_dh_auto_install"
in debian/rules (see dh_auto_install(1) for details). This is because we
do not want "make install" to be run automatically as we need the
--install-layout=deb of "setup.py install". Otherwise, files end up in
$DESTDIR/usr/local. At the moment, this is not a problem since files
installed in debian/tmp (the default location) are not packed into
binary packages (because there are debian/mercurial and
debian/mercurial-common directories). This is cleaner to avoid running
make more than needed.

Patch

diff --git a/contrib/packaging/debian/rules b/contrib/packaging/debian/rules
index 934f15e..90251c2 100755
--- a/contrib/packaging/debian/rules
+++ b/contrib/packaging/debian/rules
@@ -25,7 +25,7 @@  override_dh_auto_build:
 	$(MAKE) all
 	$(MAKE) -C contrib/chg all
 
-override_dh_install:
+override_dh_auto_install:
 	python3 setup.py install --root "$(CURDIR)"/debian/mercurial --install-layout=deb
 	# chg
 	make -C contrib/chg \