Patchwork [4,of,4,STABLE] packaging: ship only a single binary Debian package

# HG changeset patch
# User Denis Laxalde <denis.laxalde@logilab.fr>
# Date 1571843896 -7200
#      Wed Oct 23 17:18:16 2019 +0200
# Branch stable
# Node ID 9c048b5fa9f02e7a1959e763dcb5e9fa920766f5
# Parent  11c85873e106c85621ef85b67b3c64788e24a8d3
packaging: ship only a single binary Debian package

We merge the mercurial and mercurial-common binary packages into a
single mercurial package. This is essentially to ease installation (and
upgrade) using a simple "dpkg -i" command. This also simplifies
debian/rules by removing arch (in)dependent cleanups during
installation.

We have the mercurial binary Breaks: and Replaces: mercurial-common so
that the latter will be removed upon upgrade.

Also note the change from "override_dh_install" to
"override_dh_auto_install" in debian/rules: this is because we do not
want "make install" to be run automatically as we need the
--install-layout=deb of "setup.py install" (otherwise, files would end
up in $DESTDIR/usr/local).

On Wed, 23 Oct 2019 17:22:22 +0200, Denis Laxalde wrote:
> # HG changeset patch
> # User Denis Laxalde <denis.laxalde@logilab.fr>
> # Date 1571843896 -7200
> #      Wed Oct 23 17:18:16 2019 +0200
> # Branch stable
> # Node ID 9c048b5fa9f02e7a1959e763dcb5e9fa920766f5
> # Parent  11c85873e106c85621ef85b67b3c64788e24a8d3
> packaging: ship only a single binary Debian package

> +Replaces: mercurial-common (<< ${source:Version})
> +Breaks: mercurial-common (<< ${source:Version})

I'm not pretty sure if replaces/breaks should be versioned because our
package will conflicts with future official mercurial-common packages.
But that wouldn't matter since our package wouldn't be used if there are
more recent versions available in the debian repository.

On Thu, Oct 24, 2019 at 6:22 AM Yuya Nishihara <yuya@tcha.org> wrote:

> On Wed, 23 Oct 2019 17:22:22 +0200, Denis Laxalde wrote:
> > # HG changeset patch
> > # User Denis Laxalde <denis.laxalde@logilab.fr>
> > # Date 1571843896 -7200
> > #      Wed Oct 23 17:18:16 2019 +0200
> > # Branch stable
> > # Node ID 9c048b5fa9f02e7a1959e763dcb5e9fa920766f5
> > # Parent  11c85873e106c85621ef85b67b3c64788e24a8d3
> > packaging: ship only a single binary Debian package
>
> > +Replaces: mercurial-common (<< ${source:Version})
> > +Breaks: mercurial-common (<< ${source:Version})
>
> I'm not pretty sure if replaces/breaks should be versioned because our
> package will conflicts with future official mercurial-common packages.
> But that wouldn't matter since our package wouldn't be used if there are
> more recent versions available in the debian repository.
>

Mike,

Would you mind looking this over real quick to see if we're doing Debian
packaging correctly?

Yuya Nishihara a écrit :
> On Wed, 23 Oct 2019 17:22:22 +0200, Denis Laxalde wrote:
> > # HG changeset patch
> > # User Denis Laxalde <denis.laxalde@logilab.fr>
> > # Date 1571843896 -7200
> > #      Wed Oct 23 17:18:16 2019 +0200
> > # Branch stable
> > # Node ID 9c048b5fa9f02e7a1959e763dcb5e9fa920766f5
> > # Parent  11c85873e106c85621ef85b67b3c64788e24a8d3
> > packaging: ship only a single binary Debian package
> 
> > +Replaces: mercurial-common (<< ${source:Version})
> > +Breaks: mercurial-common (<< ${source:Version})
> 
> I'm not pretty sure if replaces/breaks should be versioned because our
> package will conflicts with future official mercurial-common packages.
> But that wouldn't matter since our package wouldn't be used if there are
> more recent versions available in the debian repository.

The version information in Replaces:/Breaks: are indeed problematic if we
try to install our package over the one currently in
Debian (e.g. the one in experimental).

  $ sudo apt install mercurial/experimental
  [...]
  $ sudo apt install ./packages/debian-buster/mercurial_5.2~rc0+15-buster-a2ff3aff81d2_amd64.deb
  Reading package lists... Done
  Building dependency tree       
  Reading state information... Done
  Note, selecting 'mercurial' instead of './packages/debian-buster/mercurial_5.2~rc0+15-buster-a2ff3aff81d2_amd64.deb'
  Some packages could not be installed. This may mean that you have
  requested an impossible situation or if you are using the unstable
  distribution that some required packages have not yet been created
  or been moved out of Incoming.
  The following information may help to resolve the situation:
  
  The following packages have unmet dependencies:
   mercurial : Breaks: mercurial-common (< 5.2~rc0+15-buster-a2ff3aff81d2) but 5.2~rc0-1 is to be installed
  E: Unable to correct problems, you have held broken packages.

Without (<< ${source:Version}), the install works fine.
I'll send a follow-up.

On Wed, Oct 23, 2019 at 05:22:22PM +0200, Denis Laxalde wrote:
> packaging: ship only a single binary Debian package
> 
> We merge the mercurial and mercurial-common binary packages into a
> single mercurial package. This is essentially to ease installation (and
> upgrade) using a simple "dpkg -i" command. This also simplifies
> debian/rules by removing arch (in)dependent cleanups during
> installation.
> 
> We have the mercurial binary Breaks: and Replaces: mercurial-common so
> that the latter will be removed upon upgrade.
> 
Diverging from the debian packaging this way is super bad, means you
can't cleanly go back to the debian-provided version.  And the provided
rationale seems quite dubious to me.

Cheers,
Julien

Julien Cristau a écrit :
> On Wed, Oct 23, 2019 at 05:22:22PM +0200, Denis Laxalde wrote:
> > packaging: ship only a single binary Debian package
> > 
> > We merge the mercurial and mercurial-common binary packages into a
> > single mercurial package. This is essentially to ease installation (and
> > upgrade) using a simple "dpkg -i" command. This also simplifies
> > debian/rules by removing arch (in)dependent cleanups during
> > installation.
> > 
> > We have the mercurial binary Breaks: and Replaces: mercurial-common so
> > that the latter will be removed upon upgrade.
> > 
> Diverging from the debian packaging this way is super bad, means you
> can't cleanly go back to the debian-provided version.  And the provided
> rationale seems quite dubious to me.

Can you elaborate on "super bad" and "can't cleanly go back"? As far as
I can tell, after having install the in-repo single binary package,
running "apt install mercurial/stable" works fine and gives back the
debian-provided version.