From patchwork Mon Oct 14 17:57:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: D7095: widening: remove pointless code for second changegroup From: phabricator X-Patchwork-Id: 42333 Message-Id: To: Phabricator Cc: mercurial-devel@mercurial-scm.org Date: Mon, 14 Oct 2019 17:57:14 +0000 martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The caller passes in common==heads, so we will never find any nodes to visit in this code and there will therefore never be a second changegroup emitted. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7095 AFFECTED FILES hgext/narrow/narrowbundle2.py CHANGE DETAILS To: martinvonz, durin42, #hg-reviewers Cc: mercurial-devel diff --git a/hgext/narrow/narrowbundle2.py b/hgext/narrow/narrowbundle2.py --- a/hgext/narrow/narrowbundle2.py +++ b/hgext/narrow/narrowbundle2.py @@ -186,28 +186,6 @@ if b'treemanifest' in repo.requirements: part.addparam(b'treemanifest', b'1') - visitnodes, relevant_nodes, ellipsisroots = exchange._computeellipsis( - repo, common, heads, set(), newmatch, depth=depth - ) - - repo.ui.debug(b'Found %d relevant revs\n' % len(relevant_nodes)) - if visitnodes: - packer = changegroup.getbundler( - version, - repo, - matcher=newmatch, - ellipses=True, - shallow=depth is not None, - ellipsisroots=ellipsisroots, - fullnodes=relevant_nodes, - ) - cgdata = packer.generate(common, visitnodes, False, b'narrow_widen') - - part = bundler.newpart(b'changegroup', data=cgdata) - part.addparam(b'version', version) - if b'treemanifest' in repo.requirements: - part.addparam(b'treemanifest', b'1') - @bundle2.parthandler(_SPECPART, (_SPECPART_INCLUDE, _SPECPART_EXCLUDE)) def _handlechangespec_2(op, inpart):