From patchwork Fri Oct 11 17:55:49 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: D7056: phabricator: include bookmark in diff metadata
From: phabricator <phabricator@mercurial-scm.org>
X-Patchwork-Id: 42238
Message-Id: <598bab30e0f7bb8d0542095556e07ea2@localhost.localdomain>
To: Phabricator <phabricator@mercurial-scm.org>
Cc: mercurial-devel@mercurial-scm.org
Date: Fri, 11 Oct 2019 17:55:49 +0000

Kwan added a comment.
Kwan updated this revision to Diff 17086.


  Fix some test-check-code issues, and one test-check-pyflakes unused local.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7056?vs=17062&id=17086

BRANCH
  creatediff (bookmark) on default (branch)

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7056/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7056

AFFECTED FILES
  hgext/phabricator.py

CHANGE DETAILS




To: Kwan, #hg-reviewers
Cc: mercurial-devel

diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -828,9 +828,11 @@
     repo = ctx.repo()
     repophid = getrepophid(repo)
     # Create a "Differential Diff" via "differential.creatediff" API
+    bookmark = ctx.bookmarks()[0] if ctx.bookmarks() else None
     pdiff = phabdiff(
         sourceControlBaseRevision=b'%s' % ctx.p1().hex(),
         branch=b'%s' % ctx.branch(),
+        bookmark=bookmark,
     )
     modified, added, removed, _d, _u, _i, _c = ctx.p1().status(ctx)
     # addadded will remove moved files from removed, so addremoved won't get