Patchwork D7056: phabricator: include bookmark in diff metadata

login
register
mail settings
Submitter phabricator
Date Oct. 10, 2019, 9:53 p.m.
Message ID <differential-rev-PHID-DREV-3a6b7bu6dkypaa65nzvg-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/42212/
State Superseded
Headers show

Comments

phabricator - Oct. 10, 2019, 9:53 p.m.
Kwan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  While arcanist does this I could see us leaving it out for a couple reasons:
  
  1. arcanist only operates on the current stack, so can use the actual active bookmark, whereas phabsend works with any commits, so if there are multiple bookmarks it'll just pick the first one arbitrarily
  2. some users might not like the disclosure

REPOSITORY
  rHG Mercurial

BRANCH
  creatediff (bookmark) on default (branch)

REVISION DETAIL
  https://phab.mercurial-scm.org/D7056

AFFECTED FILES
  hgext/phabricator.py

CHANGE DETAILS




To: Kwan, #hg-reviewers
Cc: mercurial-devel
phabricator - Oct. 16, 2019, 8:43 p.m.
durin42 added a comment.


  Yeah, the bookmark-name disclosure seems like something that should be optional? Maybe put this behind a flag?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7056/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7056

To: Kwan, #hg-reviewers
Cc: durin42, mercurial-devel
phabricator - Oct. 16, 2019, 8:44 p.m.
durin42 added a comment.


  (or a config knob)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7056/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7056

To: Kwan, #hg-reviewers
Cc: durin42, mercurial-devel
phabricator - Oct. 23, 2019, 9:20 p.m.
Kwan added a comment.
Kwan abandoned this revision.


  I'm not that bothered about this so going to abandon it for now, can always revisit it later.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7056/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7056

To: Kwan, #hg-reviewers
Cc: durin42, mercurial-devel
phabricator - June 7, 2022, 10:50 a.m.
Herald added a subscriber: mercurial-patches.
gecihijexy added a comment.


  Phabicator has the bookmarks in different metadata that is available for integrating multiple platforms. If you don’t find bookmarks then follow these steps best essay writing service in usa <https://www.essayuniverse.net/best-essay-writing-services/> to pick the one arbitrarily without disclosure.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7056/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7056

To: Kwan, #hg-reviewers
Cc: gecihijexy, mercurial-patches, durin42, mercurial-devel

Patch

diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -829,9 +829,11 @@ 
     repo = ctx.repo()
     repophid = getrepophid(repo)
     # Create a "Differential Diff" via "differential.creatediff" API
+    bookmark = ctx.bookmarks()[0] if ctx.bookmarks() else None
     pdiff = phabdiff(
         sourceControlBaseRevision=b'%s' % ctx.p1().hex(),
         branch=b'%s' % ctx.branch(),
+        bookmark=bookmark,
     )
     modified, added, removed, _d, _u, _i, _c = ctx.p1().status(ctx)
     # addadded will remove moved files from removed, so addremoved won't get