Patchwork [1,of,2] perf: fix `perfhelper-pathcopies` report of #changesets

login
register
mail settings
Submitter Pierre-Yves David
Date Oct. 10, 2019, noon
Message ID <cf8bf5943aa4c02257cd.1570708808@nodosa.octobus.net>
Download mbox | patch
Permalink /patch/42184/
State Accepted
Headers show

Comments

Pierre-Yves David - Oct. 10, 2019, noon
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@octobus.net>
# Date 1570055960 14400
#      Wed Oct 02 18:39:20 2019 -0400
# Node ID cf8bf5943aa4c02257cd1b4227f5f01d7a37a497
# Parent  c88075eb28e3281a4470fde929fbf5a13bda5f8a
# EXP-Topic perfhelper
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r cf8bf5943aa4
perf: fix `perfhelper-pathcopies` report of #changesets

The previous computation `<base>::<target>` was wrong, what we actually need is
`::<target> - ::<base>`.

This is now fixed
Pulkit Goyal - Oct. 10, 2019, 1:16 p.m.
On Thu, Oct 10, 2019 at 3:06 PM Pierre-Yves David
<pierre-yves.david@ens-lyon.org> wrote:
>
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@octobus.net>
> # Date 1570055960 14400
> #      Wed Oct 02 18:39:20 2019 -0400
> # Node ID cf8bf5943aa4c02257cd1b4227f5f01d7a37a497
> # Parent  c88075eb28e3281a4470fde929fbf5a13bda5f8a
> # EXP-Topic perfhelper
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r cf8bf5943aa4
> perf: fix `perfhelper-pathcopies` report of #changesets
>
> The previous computation `<base>::<target>` was wrong, what we actually need is
> `::<target> - ::<base>`.
>
> This is now fixed

Queued the series, many thanks!

Patch

diff --git a/contrib/perf.py b/contrib/perf.py
--- a/contrib/perf.py
+++ b/contrib/perf.py
@@ -2122,7 +2122,7 @@  def perfhelperpathcopies(ui, repo, revs=
                 data = {
                     b'source': base.hex(),
                     b'destination': parent.hex(),
-                    b'nbrevs': len(repo.revs('%d::%d', b, p)),
+                    b'nbrevs': len(repo.revs('only(%d, %d)', p, b)),
                     b'nbmissingfiles': len(missing),
                 }
                 if dostats: