Patchwork [1,of,2] crecord: drop duplicated set of firstlineofpadtoprint attribute

login
register
mail settings
Submitter Denis Laxalde
Date Oct. 10, 2019, 10:34 a.m.
Message ID <d1e7685793ec19e64937.1570703675@steppe.local>
Download mbox | patch
Permalink /patch/42182/
State Accepted
Headers show

Comments

Denis Laxalde - Oct. 10, 2019, 10:34 a.m.
# HG changeset patch
# User Denis Laxalde <denis.laxalde@logilab.fr>
# Date 1570702823 -7200
#      Thu Oct 10 12:20:23 2019 +0200
# Node ID d1e7685793ec19e649370c77965d492a71aed30c
# Parent  52781d57313d512efb7150603104bea3ca11d0eb
crecord: drop duplicated set of firstlineofpadtoprint attribute

The attribute is already set a couple of lines above, in
curseschunkselector.__init__().
Pulkit Goyal - Oct. 10, 2019, 1:20 p.m.
On Thu, Oct 10, 2019 at 1:37 PM Denis Laxalde <denis@laxalde.org> wrote:
>
> # HG changeset patch
> # User Denis Laxalde <denis.laxalde@logilab.fr>
> # Date 1570702823 -7200
> #      Thu Oct 10 12:20:23 2019 +0200
> # Node ID d1e7685793ec19e649370c77965d492a71aed30c
> # Parent  52781d57313d512efb7150603104bea3ca11d0eb
> crecord: drop duplicated set of firstlineofpadtoprint attribute
>
> The attribute is already set a couple of lines above, in
> curseschunkselector.__init__().

Queued these, many thanks!
Yuya Nishihara - Oct. 10, 2019, 1:26 p.m.
On Thu, 10 Oct 2019 12:34:35 +0200, Denis Laxalde wrote:
> # HG changeset patch
> # User Denis Laxalde <denis.laxalde@logilab.fr>
> # Date 1570702823 -7200
> #      Thu Oct 10 12:20:23 2019 +0200
> # Node ID d1e7685793ec19e649370c77965d492a71aed30c
> # Parent  52781d57313d512efb7150603104bea3ca11d0eb
> crecord: drop duplicated set of firstlineofpadtoprint attribute

Queued, thanks.

Patch

diff --git a/mercurial/crecord.py b/mercurial/crecord.py
index 3d66e0f..32f77d8 100644
--- a/mercurial/crecord.py
+++ b/mercurial/crecord.py
@@ -678,9 +678,6 @@  class curseschunkselector(object):
         # (used for determining when the selected item begins/ends)
         self.linesprintedtopadsofar = 0
 
-        # the first line of the pad which is visible on the screen
-        self.firstlineofpadtoprint = 0
-
         # stores optional text for a commit comment provided by the user
         self.commenttext = b""