D6995: debugsidedata: fix verbose mode on python3

Submitter	phabricator
Date	Oct. 6, 2019, 2:26 p.m.
Message ID	<differential-rev-PHID-DREV-ieofy4mq6taixjcygmef-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/42012/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Sun, 6 Oct 2019 14:26:59 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "marmoute (Pierre-Yves David)" <phabricator@mercurial-scm.org> Subject: D6995: debugsidedata: fix verbose mode on python3 Message-ID: <differential-rev-PHID-DREV-ieofy4mq6taixjcygmef-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-ieofy4mq6taixjcygmef Thread-Index: NGRiNmZjM2MxNDU0NGZjNTJkYWMxYTkyMzQ0 MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "marmoute \(Pierre-Yves David\)" <phabricator+D6995+public+bf192527fab62d20@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Oct. 6, 2019, 2:26 p.m.

marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We need to be gently with python3 for it to display this binary data.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6995

AFFECTED FILES
  mercurial/debugcommands.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/debugcommands.py b/mercurial/debugcommands.py
--- a/mercurial/debugcommands.py
+++ b/mercurial/debugcommands.py
@@ -2663,7 +2663,7 @@ 
         for key, value in sidedata:
             ui.write((' entry-%04o size %d\n' % (key, len(value))))
             if ui.verbose:
-                ui.write(('  %s\n' % repr(value)))
+                ui.write(('  %s\n' % stringutil.pprint(value)))
 
 @command('debugssl', [], '[SOURCE]', optionalrepo=True)
 def debugssl(ui, repo, source=None, **opts):

Patchwork D6995: debugsidedata: fix verbose mode on python3

Comments

Patch