| Submitter | phabricator |
|---|---|
| Date | Sept. 26, 2019, 5:47 p.m. |
| Message ID | <differential-rev-PHID-DREV-g5qsdjcbhdsvgtw3fpi5-req@mercurial-scm.org> |
| Download | mbox | patch |
| Permalink | /patch/41777/ |
| State | Superseded |
| Headers | show |
Comments
pulkit added a comment. Thanks! In D6884 <https://phab.mercurial-scm.org/D6884>'s commit message, Augie used the releasenotes format. So this is not required. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6885/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6885 To: martinvonz, #hg-reviewers Cc: pulkit, mercurial-devel
martinvonz added a comment.
In D6885#101094 <https://phab.mercurial-scm.org/D6885#101094>, @pulkit wrote:
> Thanks! In D6884 <https://phab.mercurial-scm.org/D6884>'s commit message, Augie used the releasenotes format. So this is not required.
I know, I was just trying to save us from have to merge the two when the new release is ready
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6885/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6885
To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel
martinvonz added a comment. In D6885#101096 <https://phab.mercurial-scm.org/D6885#101096>, @martinvonz wrote: > In D6885#101094 <https://phab.mercurial-scm.org/D6885#101094>, @pulkit wrote: > >> Thanks! In D6884 <https://phab.mercurial-scm.org/D6884>'s commit message, Augie used the releasenotes format. So this is not required. > > I know, I was just trying to save us from have to merge the two when the new release is ready (Sorry, sent prematurely) I think we just used the relnotes/next file for last release and only put the output from the script on a separate page. But I may misremember. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6885/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6885 To: martinvonz, #hg-reviewers Cc: pulkit, mercurial-devel
marmoute added a comment. I am a bit confused about this diff, is this still required ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6885/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6885 To: martinvonz, #hg-reviewers Cc: marmoute, pulkit, mercurial-devel
martinvonz added a comment.
In D6885#102923 <https://phab.mercurial-scm.org/D6885#102923>, @marmoute wrote:
> I am a bit confused about this diff, is this still required ?
No, I thought it would be helpful to have all the release notes in one place, but I think the consensus was that we'll keep release notes in both relnotes/next and in commit messages and then just merge them when it's time for a release. I'll drop this patch.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6885/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6885
To: martinvonz, #hg-reviewers
Cc: marmoute, pulkit, mercurial-devel
Patch
diff --git a/relnotes/next b/relnotes/next --- a/relnotes/next +++ b/relnotes/next @@ -28,3 +28,7 @@ == Internal API Changes == + * `mercurial.bookmarks.bmstore` no longer has a convenience method + for looking up changectx instances from a bookmark name. Use + `repo[repo.bookmarks[name]]` intead of + `repo.bookmarks.changectx(name)`.