Patchwork D6823: flagprocessors: remove flagprocessorsmixin

login
register
mail settings
Submitter phabricator
Date Sept. 9, 2019, 9:26 p.m.
Message ID <df3cced21a8dddaec0ce90c6423ae896@localhost.localdomain>
Download mbox | patch
Permalink /patch/41617/
State Not Applicable
Headers show

Comments

phabricator - Sept. 9, 2019, 9:26 p.m.
marmoute updated this revision to Diff 16489.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6823?vs=16428&id=16489

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6823/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6823

AFFECTED FILES
  hgext/remotefilelog/remotefilelog.py
  mercurial/revlog.py
  mercurial/revlogutils/flagutil.py
  tests/simplestorerepo.py

CHANGE DETAILS




To: marmoute, yuja, durin42, indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/simplestorerepo.py b/tests/simplestorerepo.py
--- a/tests/simplestorerepo.py
+++ b/tests/simplestorerepo.py
@@ -91,7 +91,7 @@ 
     node = attr.ib(default=None)
 
 @interfaceutil.implementer(repository.ifilestorage)
-class filestorage(flagutil.flagprocessorsmixin):
+class filestorage(object):
     """Implements storage for a tracked path.
 
     Data is stored in the VFS in a directory corresponding to the tracked
diff --git a/mercurial/revlogutils/flagutil.py b/mercurial/revlogutils/flagutil.py
--- a/mercurial/revlogutils/flagutil.py
+++ b/mercurial/revlogutils/flagutil.py
@@ -79,14 +79,6 @@ 
         raise error.Abort(msg)
     flagprocessors[flag] = processor
 
-class flagprocessorsmixin(object):
-    """basic mixin to support revlog flag processing
-
-    Make sure the `_flagprocessors` attribute is set at ``__init__`` time.
-
-    See the documentation of the ``_processflags`` method for details.
-    """
-
 def processflagswrite(revlog, text, flags, sidedata):
     """Inspect revision data flags and applies write transformations defined
     by registered flag processors.
diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -261,7 +261,7 @@ 
             p = versionformat_pack(version) + p[4:]
         return p
 
-class revlog(flagutil.flagprocessorsmixin):
+class revlog(object):
     """
     the underlying revision storage object
 
diff --git a/hgext/remotefilelog/remotefilelog.py b/hgext/remotefilelog/remotefilelog.py
--- a/hgext/remotefilelog/remotefilelog.py
+++ b/hgext/remotefilelog/remotefilelog.py
@@ -47,7 +47,7 @@ 
             raise KeyError(node)
         return node
 
-class remotefilelog(flagutil.flagprocessorsmixin):
+class remotefilelog(object):
 
     _generaldelta = True
     _flagserrorclass = error.RevlogError