Patchwork D6770: rust: fix warnings about trait objects without dyn being deprecated

login
register
mail settings
Submitter phabricator
Date Aug. 31, 2019, 10:59 p.m.
Message ID <4b4c36576d2a61495855f6c7570e4bc5@localhost.localdomain>
Download mbox | patch
Permalink /patch/41457/
State Not Applicable
Headers show

Comments

phabricator - Aug. 31, 2019, 10:59 p.m.
Closed by commit rHGae2a4ef8af02: rust: fix warnings about trait objects without dyn being deprecated (authored by valentin.gatienbaron).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6770?vs=16331&id=16354

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6770/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6770

AFFECTED FILES
  rust/hg-cpython/src/ref_sharing.rs

CHANGE DETAILS




To: valentin.gatienbaron, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel

Patch

diff --git a/rust/hg-cpython/src/ref_sharing.rs b/rust/hg-cpython/src/ref_sharing.rs
--- a/rust/hg-cpython/src/ref_sharing.rs
+++ b/rust/hg-cpython/src/ref_sharing.rs
@@ -345,7 +345,7 @@ 
             $name,
             $leaked,
             Box<
-                Iterator<Item = (&'static $key_type, &'static $value_type)>
+                dyn Iterator<Item = (&'static $key_type, &'static $value_type)>
                     + Send,
             >,
             $success_func,
@@ -367,7 +367,7 @@ 
         py_shared_iterator_impl!(
             $name,
             $leaked,
-            Box<Iterator<Item = &'static $key_type> + Send>,
+            Box<dyn Iterator<Item = &'static $key_type> + Send>,
             $success_func,
             $success_type
         );