Patchwork [2,of,2] contrib: explicitly enable perf extension for revset tests

login
register
mail settings
Submitter Olle Lundberg
Date March 25, 2014, 10:11 p.m.
Message ID <70f6451218676456ac47.1395785515@se-c02kq0dadr55.lan>
Download mbox | patch
Permalink /patch/4066/
State Accepted
Commit 44e80bf2688f0e8f0734a26a3be1c546a6ac7ca6
Headers show

Comments

Olle Lundberg - March 25, 2014, 10:11 p.m.
# HG changeset patch
# User Olle Lundberg <geek@nerd.sh>
# Date 1395785415 -3600
#      Tue Mar 25 23:10:15 2014 +0100
# Node ID 70f6451218676456ac47fa3b75fbcef37fabf96d
# Parent  5c9e0e96192c55a6cd4e468b0f72f8f4d339c82e
contrib: explicitly enable perf extension for revset tests

If a developer doesn't have the perf extension enabled the revset
benchmarking will fail. This patch explicitly enables the
perf extension when running the tests.
David Soria Parra - March 26, 2014, 1:46 a.m.
Olle Lundberg <olle.lundberg@gmail.com> writes:

> # HG changeset patch
> # User Olle Lundberg <geek@nerd.sh>
> # Date 1395785415 -3600
> #      Tue Mar 25 23:10:15 2014 +0100
> # Node ID 70f6451218676456ac47fa3b75fbcef37fabf96d
> # Parent  5c9e0e96192c55a6cd4e468b0f72f8f4d339c82e
> contrib: explicitly enable perf extension for revset tests
>
> If a developer doesn't have the perf extension enabled the revset
> benchmarking will fail. This patch explicitly enables the
> perf extension when running the tests.
>
> diff --git a/contrib/revsetbenchmarks.sh b/contrib/revsetbenchmarks.sh
> --- a/contrib/revsetbenchmarks.sh
> +++ b/contrib/revsetbenchmarks.sh
> @@ -12,12 +12,12 @@
>  #
>  # This script also does one run of the current version of mercurial installed
>  # to compare performance.
>  
>  HG="hg update"
> -PERF="./hg perfrevset"
> -BASE_PERF="hg perfrevset"
> +PERF="./hg --config extensions.perf=contrib/perf.py perfrevset"
> +BASE_PERF="hg --config extensions.perf=contrib/perf.py perfrevset"

This looks good. Thank you, queued to default.

Patch

diff --git a/contrib/revsetbenchmarks.sh b/contrib/revsetbenchmarks.sh
--- a/contrib/revsetbenchmarks.sh
+++ b/contrib/revsetbenchmarks.sh
@@ -12,12 +12,12 @@ 
 #
 # This script also does one run of the current version of mercurial installed
 # to compare performance.
 
 HG="hg update"
-PERF="./hg perfrevset"
-BASE_PERF="hg perfrevset"
+PERF="./hg --config extensions.perf=contrib/perf.py perfrevset"
+BASE_PERF="hg --config extensions.perf=contrib/perf.py perfrevset"
 
 TARGETS=$1
 shift
 # read from a file or from standard output
 if [ $# -ne 0 ]; then