Patchwork D6560: copies: remove a redundant matcher filtering in _changesetforwardcopies()

login
register
mail settings
Submitter phabricator
Date June 20, 2019, 9:09 p.m.
Message ID <differential-rev-PHID-DREV-aakobdv66zcst6ylsamx-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/40632/
State Superseded
Headers show

Comments

phabricator - June 20, 2019, 9:09 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We filter before pushing items on the queue, so we don't need to
  filter after popping.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6560

AFFECTED FILES
  mercurial/copies.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/copies.py b/mercurial/copies.py
--- a/mercurial/copies.py
+++ b/mercurial/copies.py
@@ -279,8 +279,6 @@ 
             copies = {}
             allcopies = set(copies1) | set(copies2)
             for dst in allcopies:
-                if not alwaysmatch and not match(dst):
-                    continue
                 # Unlike when copies are stored in the filelog, we consider
                 # it a copy even if the destination already existed on the
                 # other branch. It's simply too expensive to check if the