Patchwork D6559: copies: delete obsolete comment in _changesetforwardcopies()

login
register
mail settings
Submitter phabricator
Date June 20, 2019, 9:09 p.m.
Message ID <differential-rev-PHID-DREV-lryshbtufogtnvqioffv-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/40631/
State Superseded
Headers show

Comments

phabricator - June 20, 2019, 9:09 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  IIRC, the comment applied to the filtering we did before 35d674a3d5db <https://phab.mercurial-scm.org/rHG35d674a3d5db319b47560f1ef8949b0f77c1cafb>
  (copies: don't filter out copy targets created on other side of merge
  commit, 2019-04-18).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6559

AFFECTED FILES
  mercurial/copies.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/copies.py b/mercurial/copies.py
--- a/mercurial/copies.py
+++ b/mercurial/copies.py
@@ -278,8 +278,6 @@ 
             r, i2, copies2 = heapq.heappop(work)
             copies = {}
             allcopies = set(copies1) | set(copies2)
-            # TODO: perhaps this filtering should be done as long as ctx
-            # is merge, whether or not we're tracing from both parent.
             for dst in allcopies:
                 if not alwaysmatch and not match(dst):
                     continue