Patchwork [1,of,4,accept-scripts] blocker: don't walk over non-drafts when looking for blockers

login
register
mail settings
Submitter Augie Fackler
Date June 12, 2019, 4:52 a.m.
Message ID <eaf44a303cf907051ec2.1560315142@augie-macbookpro2.roam.corp.google.com>
Download mbox | patch
Permalink /patch/40438/
State New
Headers show

Comments

Augie Fackler - June 12, 2019, 4:52 a.m.
# HG changeset patch
# User Augie Fackler <raf@durin42.com>
# Date 1560312695 14400
#      Wed Jun 12 00:11:35 2019 -0400
# Node ID eaf44a303cf907051ec24a17c3b5899edcb44e8f
# Parent  28ae2b494815758b750e0ab36433a20f3e580ab5
blocker: don't walk over non-drafts when looking for blockers

This bug was obscuring a real problem for a long time. Sigh.

Patch

diff --git a/blocker b/blocker
--- a/blocker
+++ b/blocker
@@ -6,7 +6,7 @@  import accept
 import config
 
 cq = accept.commitqueue(config.load().source)
-for n in cq.commits():
+for n in cq.draft():
     a = cq.accepted(n)
     if not a:
         print n, " ".join(cq.accepters(n))