Patchwork D6470: mixedrepostorecache: fix a silly redundant updating of set

login
register
mail settings
Submitter phabricator
Date June 1, 2019, 5:55 a.m.
Message ID <differential-rev-PHID-DREV-6mtsorrct5x3kvjl3d3x-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/40294/
State Superseded
Headers show

Comments

phabricator - June 1, 2019, 5:55 a.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6470

AFFECTED FILES
  mercurial/localrepo.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -128,8 +128,7 @@ 
         # scmutil.filecache only uses the path for passing back into our
         # join(), so we can safely pass a list of paths and locations
         super(mixedrepostorecache, self).__init__(*pathsandlocations)
-        for path, location in pathsandlocations:
-            _cachedfiles.update(pathsandlocations)
+        _cachedfiles.update(pathsandlocations)
 
     def join(self, obj, fnameandlocation):
         fname, location = fnameandlocation