Patchwork D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145)

login
register
mail settings
Submitter phabricator
Date May 25, 2019, 11:54 a.m.
Message ID <965c04b787318aa9d246ba5a5b4b7ffa@localhost.localdomain>
Download mbox | patch
Permalink /patch/40233/
State Not Applicable
Headers show

Comments

phabricator - May 25, 2019, 11:54 a.m.
ngoldbaum updated this revision to Diff 15258.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6441?vs=15246&id=15258

REVISION DETAIL
  https://phab.mercurial-scm.org/D6441

AFFECTED FILES
  mercurial/help.py

CHANGE DETAILS




To: ngoldbaum, #hg-reviewers, martinvonz
Cc: martinvonz, av6, mercurial-devel

Patch

diff --git a/mercurial/help.py b/mercurial/help.py
--- a/mercurial/help.py
+++ b/mercurial/help.py
@@ -689,6 +689,8 @@ 
             for names, header, doc in subtopics[name]:
                 if subtopic in names:
                     break
+            if not any(subtopic in names for names, _, _ in subtopics[name]):
+                raise error.UnknownCommand(name)
 
         if not header:
             for topic in helptable: