Patchwork D6444: narrow: pass binary nodeids to generateellipsesbundle2()

login
register
mail settings
Submitter phabricator
Date May 24, 2019, 1:02 p.m.
Message ID <differential-rev-PHID-DREV-dxlfxqhqdkckaa6ovyo4-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/40225/
State Superseded
Headers show

Comments

phabricator - May 24, 2019, 1:02 p.m.
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We generally work with binary nodeids and it's should be expected that new
  function gets the nodeids in binary form already.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6444

AFFECTED FILES
  hgext/narrow/narrowbundle2.py

CHANGE DETAILS




To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/narrow/narrowbundle2.py b/hgext/narrow/narrowbundle2.py
--- a/hgext/narrow/narrowbundle2.py
+++ b/hgext/narrow/narrowbundle2.py
@@ -61,8 +61,9 @@ 
     oldexclude = sorted(filter(bool, kwargs.get(r'oldexcludepats', [])))
     newinclude = sorted(filter(bool, kwargs.get(r'includepats', [])))
     newexclude = sorted(filter(bool, kwargs.get(r'excludepats', [])))
+    known = {bin(n) for n in kwargs.get('known', [])}
     generateellipsesbundle2(bundler, repo, oldinclude, oldexclude, newinclude,
-            newexclude, version, common, kwargs.get('known', []),
+            newexclude, version, common, known,
             kwargs.get(r'depth', None), heads)
 
 def generateellipsesbundle2(bundler, repo, oldinclude, oldexclude, newinclude,
@@ -76,7 +77,6 @@ 
 
     heads = set(heads or repo.heads())
     common = set(common or [nullid])
-    known = {bin(n) for n in known}
     if known and (oldinclude != newinclude or oldexclude != newexclude):
         # Steps:
         # 1. Send kill for "$known & ::common"